-
Notifications
You must be signed in to change notification settings - Fork 68
feat: [Geneva Uploader] Implement Azure Workload Identity authentication for Geneva. #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+704
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
- Coverage 53.9% 53.7% -0.3%
=======================================
Files 71 71
Lines 11220 11262 +42
=======================================
- Hits 6057 6056 -1
- Misses 5163 5206 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lalitb
commented
Oct 7, 2025
utpilla
reviewed
Oct 8, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/config_service/client.rs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 9, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/config_service/client.rs
Show resolved
Hide resolved
utpilla
reviewed
Oct 9, 2025
opentelemetry-exporter-geneva/geneva-uploader/src/config_service/client.rs
Show resolved
Hide resolved
utpilla
approved these changes
Oct 9, 2025
Added a TODO for Azure Arc support in the Geneva Config Client.
Added a TODO comment regarding the get_token API's parameter type.
Removed unnecessary check for trailing slash in scope candidates generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Implementation
Added
AuthMethod::WorkloadIdentity
variant (geneva-uploader/src/config_service/client.rs
)WorkloadIdentityCredential
for token exchangeAZURE_CLIENT_ID
,AZURE_TENANT_ID
, andAZURE_FEDERATED_TOKEN_FILE
from environment/userapi
endpoint (same as Managed Identity authentication)Token acquisition and caching
Example and Documentation
Complete working example (
examples/basic_workload_identity_test.rs
)Comprehensive setup guide (
examples/README.md
)Docker support (
examples/Dockerfile
)FFI Support
geneva-uploader-ffi/src/lib.rs
)AZURE_FEDERATED_TOKEN_FILE
presenceMerge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes