clipp

Author: cijothomas

opentelemetry-sdk/src/metrics/periodic_reader.rs

@@ -361,7 +361,7 @@ impl<E: PushMetricExporter> PeriodicReaderInner<E> {
         let producer = self.producer.lock().expect("lock poisoned");
         if let Some(p) = producer.as_ref() {
             p.upgrade()
-                .ok_or_else(|| OTelSdkError::AlreadyShutdown)?
+                .ok_or(OTelSdkError::AlreadyShutdown)?
                 .produce(rm)?;
             Ok(())
         } else {

opentelemetry-sdk/src/metrics/reader.rs

@@ -46,7 +46,7 @@ pub trait MetricReader: fmt::Debug + Send + Sync + 'static {
     ///
     /// After `shutdown` is called, calls to `collect` will perform no operation and
     /// instead will return an error indicating the shutdown state.
-    fn shutdown_with_timeout(&self, timeout: Duration) -> OTelSdkResult;
+    fn shutdown_with_timeout(&self, timeout: Duration) ->   ;
 
     /// shutdown with default timeout
     fn shutdown(&self) -> OTelSdkResult {