Implement serde test #1860
Closed
Implement serde test #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramgdev
reviewed
Jun 4, 2024
| "attributes": [ | ||
| { | ||
| "key": "bogons", | ||
| "value": "100" |
There was a problem hiding this comment.
The string value here should use Value::String during serialization instead of plain string for attributes. When a number is preferred on deserialization, then it should be serialized as Value::I64.
|
fix incorporated in #1882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1856
Changes
This PR:
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changesTesting
Run new test with
cargo test --workspace --all-features --test traces 'test_serde' -- --nocapture