-
Notifications
You must be signed in to change notification settings - Fork 599
feat: update otel versions for prometheus to 0.26 #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cijothomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please update changelog.md too.
Also, see #1957 (review)
No change in Prometheus status - it may not work in next release! if it works, they good, but no guarantees.
cd704e3 to
e91f7f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
=======================================
- Coverage 79.3% 79.1% -0.2%
=======================================
Files 121 121
Lines 20944 20933 -11
=======================================
- Hits 16612 16562 -50
- Misses 4332 4371 +39 ☔ View full report in Codecov by Sentry. |
|
@ouertani Do you want to look into the CI tests for Prometheus which are failing right now ? |
Yes, I will try to fix |
See #2224 (review) |
fix: ignore prometheus_exporter_integration until fixed with sdk |
| use opentelemetry_semantic_conventions::resource::{SERVICE_NAME, TELEMETRY_SDK_VERSION}; | ||
| use prometheus::{Encoder, TextEncoder}; | ||
|
|
||
| #[ignore] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please point to the issue or the PRs trying to fix this for easy referenc.e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add the pr link
Fixes #
Design discussion issue (if applicable) #
align
opentelemetry-prometheusto0.26.0versionChanges
Please provide a brief description of the changes here.
AggregationSelectoras per AggregationSelector is not needed anymore #2085MetricProduceras per Remove MetricProducer #2105KeyValue::new()#2091Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes