Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented Oct 12, 2024

Changes

  • This PR reduces the number of public APIs exposed by removing SDK's dependency on using API's no-op versions of Meter and instruments
  • The intended behavior is retained by SDK keeping its own version of these no-op structs

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner October 12, 2024 22:46
@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (f1a6e16) to head (0727bef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/noop.rs 75.0% 6 Missing ⚠️
opentelemetry/src/metrics/noop.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2203     +/-   ##
=======================================
- Coverage   79.1%   79.0%   -0.1%     
=======================================
  Files        121     122      +1     
  Lines      21009   21033     +24     
=======================================
  Hits       16620   16620             
- Misses      4389    4413     +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is still adhering to the spirit of the spec. Happy to see the trimmed down public API as we move to declare Metrics API as RC/Stable soon.

@cijothomas cijothomas merged commit c3687d4 into open-telemetry:main Oct 13, 2024
23 of 24 checks passed
@utpilla utpilla changed the title [Metrics-API] Mark no-op structs as pub(crate) [Metrics API] Mark no-op structs as pub(crate) Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants