-
Notifications
You must be signed in to change notification settings - Fork 599
Remove default logger name #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 123 123
Lines 21334 21363 +29
=====================================
+ Hits 16972 17004 +32
+ Misses 4362 4359 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…-rust into logger-invalid-name
cijothomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>
Changes
As per the specs - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#logger-creation
In the case where an invalid name (null or empty string) is specified, a working Logger MUST be returned as a fallback rather than returning null or throwing an exception, its name SHOULD keep the original invalid value, and a message reporting that the specified value is invalid SHOULD be logged.So changed the implementation to create the instrumentation scope with empty
nameif provided and log the warning.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes