Emit internal log for global meter provider #2331
Conversation
| **provider = Arc::new(new_provider); | ||
| otel_info!(name: "MeterProvider.GlobalSet", message = "Global meter provider is set. Meters can now be created using global::meter() or global::meter_with_scope()."); | ||
| } else { | ||
| otel_error!(name: "MeterProvider.GlobalSetFailed", message = "Global meter provider is not set due to lock poison. Meters created using global::meter() or global::meter_with_scope() will not function."); |
There was a problem hiding this comment.
not sure if this (lock poison) is ever user-actionable... Maybe just state "OTel internal error occurred, report it at OpenTelemtry Github repo"?
There was a problem hiding this comment.
It's not user-actionable in its current form. If set_meter_provider returned a PoisonError, users could retrieve provider from this error object, reinitialize it to Noop and retry. In current form, it's better to log the error and instruct users to report it to the repository.
There was a problem hiding this comment.
will change it in next PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2331 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 123 123
Lines 21295 21297 +2
=======================================
+ Hits 16935 16936 +1
- Misses 4360 4361 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2 participants
Continuing from #2330.
Also realized the
opentelemetrycrate did not internal-logs ff enabled by default, and fixed it.