Modify logs basic example to use tracing #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 21485 21485
=====================================
Hits 17068 17068
Misses 4417 4417 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Dec 9, 2024
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Another option could be to have two separate examples. Existing one can be renamed to logs-basic-log (or better naming), and new one logs-basic-tracing for tracing. But this can be revisited later.
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to include few wordings in the future about preventing infinite loops, how to setup OTel as a layer to user's existing tracing pipeline etc. This PR is just first step.