Skip to content

Conversation

@djc
Copy link
Contributor

@djc djc commented Dec 10, 2024

#2303 refactored the TracerProvider builder to deprecate the Config API. I like the API changes this resulted in, but the Builder::max_events_per_span() method sets the incorrect span_limits.max_attributes_per_span field.

@djc djc requested a review from a team as a code owner December 10, 2024 09:02
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (902baa9) to head (7345df0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/trace/provider.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2405     +/-   ##
=======================================
- Coverage   79.3%   79.3%   -0.1%     
=======================================
  Files        123     123             
  Lines      21566   21566             
=======================================
- Hits       17112   17108      -4     
- Misses      4454    4458      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cijothomas cijothomas merged commit e8ccb01 into open-telemetry:main Dec 10, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants