Skip to content

Conversation

@djc
Copy link
Contributor

@djc djc commented Dec 10, 2024

The minimal version for thiserror (1) was too low, resulting in build failures with -Z minimal-versions. Upgrade to thiserror 2 instead of trying to pinpoint a better minimal version.

@djc djc requested a review from a team as a code owner December 10, 2024 09:12
@djc
Copy link
Contributor Author

djc commented Dec 10, 2024

The markdown-link-check failure appears to be a fluke.

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (e8ccb01) to head (aaa9975).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2406   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      21566   21566           
=====================================
  Hits       17112   17112           
  Misses      4454    4454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

@utpilla I think we discussed in the past about needing thiserror or not. Let us continue with this, and if we ever need to remove it, it can be done without breaking change.

@cijothomas cijothomas merged commit 2573773 into open-telemetry:main Dec 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants