Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Dec 11, 2024

Changes

Fix for the issue discussed here - #2408 (comment)

Propagation related code needn't be compiled when trace flag is disabled.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (f9581f5) to head (6109634).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2413   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        122     122           
  Lines      21539   21539           
=====================================
+ Hits       17069   17073    +4     
+ Misses      4470    4466    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit e8a2878 into open-telemetry:main Dec 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants