Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 11, 2024

Changes

  • Add internal logging for OTLP Exporter Tonic client

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner December 11, 2024 16:46
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (e4cba94) to head (12d8c0a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/logs.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/metrics.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/mod.rs 93.1% 2 Missing ⚠️
opentelemetry-otlp/src/metric.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2415     +/-   ##
=======================================
- Coverage   79.2%   79.2%   -0.1%     
=======================================
  Files        122     122             
  Lines      21516   21539     +23     
=======================================
+ Hits       17055   17073     +18     
- Misses      4461    4466      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cijothomas cijothomas merged commit f9581f5 into open-telemetry:main Dec 11, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants