Improve shutdown handling in PeriodicReader #2422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If shutdown is called from multiple threads, modify the logic so that only one enters the core logic of sending shutdown signal etc. Previously, both threads can send shutdown message to background thread, and after the 1st one, the thread exists, so the other shutdown fails. Though it is okay, the error message may not be super easy to follow.
This PR makes sure only one shutdown proceeds, the other one immediately returning a failure indicating that failure is due to shutdown already initiated. This also ensures, checking for shutdown flag is only done at user thread invoking shutdown/flush.
There is a similar race between Flush and Shutdown possible, added it as a TODO to improve log messaging.
Also added more test for drop.