Move shutdown checks to MeterProvider #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 122 122
Lines 21708 21696 -12
=======================================
- Hits 17255 17244 -11
+ Misses 4453 4452 -1 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Dec 16, 2024
|
|
||
| fn shutdown(&self) -> MetricResult<()> { | ||
| if self | ||
| .shutdown_invoked |
Member
There was a problem hiding this comment.
Just thinking - we don't need any check in periodically executed collect_and_export to not do export if shutdown is invoked?
Member
Author
There was a problem hiding this comment.
after shutdown is invoked, there is no way to invoke collect or export methods (they are not public).
I am still checking for ways to better architect this - reader is cloneable today, which I am not sure if we need to. but requires more refactoring/design..
lalitb
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure why we need to duplicate this in PeriodicReader if the MeterProvider can take care of this.
PeriodicReader will still return Error when shutdown is invoked again, but won't be as descriptive. But not something to worry, as users should only be calling flush/shutdown on the Providers, not on reader/exporter directly.