Skip to content

Conversation

@cijothomas
Copy link
Member

Some nits to improve logging.

@cijothomas cijothomas requested a review from a team as a code owner December 23, 2024 19:44
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.2%. Comparing base (1f35467) to head (abfba3a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 83.3% 1 Missing ⚠️
opentelemetry-sdk/src/trace/span_processor.rs 87.5% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2464     +/-   ##
=======================================
- Coverage   77.2%   77.2%   -0.1%     
=======================================
  Files        124     124             
  Lines      23009   23016      +7     
=======================================
+ Hits       17765   17770      +5     
- Misses      5244    5246      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas requested a review from Copilot December 23, 2024 19:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • scripts/integration_tests.sh: Language not supported

@cijothomas cijothomas added the integration tests Run integration tests label Dec 23, 2024
@cijothomas cijothomas merged commit ef49833 into open-telemetry:main Dec 23, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/nitsfollowups branch December 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration tests Run integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants