Skip to content

Conversation

@cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner December 24, 2024 05:13
@codecov
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.1%. Comparing base (8d5f222) to head (8c148a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2467   +/-   ##
=====================================
  Coverage   77.1%   77.1%           
=====================================
  Files        124     124           
  Lines      23021   23021           
=====================================
  Hits       17771   17771           
  Misses      5250    5250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring
Copy link
Member

scottgerring commented Dec 24, 2024

Good catch! 🤦
Perhaps we should change lint.sh so it runs either everywhere, or just add integration-tests?

if rustup component add clippy; then
crates=( "opentelemetry"
"opentelemetry-http"
"opentelemetry-jaeger-propagator"
"opentelemetry-appender-log"
"opentelemetry-appender-tracing"
"opentelemetry-otlp"
"opentelemetry-prometheus"
"opentelemetry-proto"
"opentelemetry-sdk"
"opentelemetry-semantic-conventions"
"opentelemetry-stdout"
"opentelemetry-zipkin")
for crate in "${crates[@]}"; do
cargo clippy --manifest-path=$crate/Cargo.toml --all-targets --all-features -- \
`# Exit with a nonzero code if there are clippy warnings` \
-Dwarnings
done

@lalitb
Copy link
Member

lalitb commented Dec 24, 2024

Good catch! 🤦 Perhaps we should change lint.sh so it runs either everywhere, or just add integration-tests?

+1

@lalitb lalitb merged commit 6e1032f into open-telemetry:main Dec 24, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/log-processor-nits branch December 24, 2024 16:31
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants