Skip to content

Conversation

@cijothomas
Copy link
Member

Was a miss in the PeriodicReader implementation that uses own thread. This was already handled in the old periodic reader.

More refactoring is expected in this area, but this addresses the gap.

@cijothomas cijothomas requested a review from a team as a code owner December 26, 2024 21:08
}

#[derive(Debug, Clone, Default)]
struct MockMetricExporter {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a future PR, I expect to replace this with InMemoryExporter itself.

@codecov
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.2%. Comparing base (36f9caf) to head (8432c18).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 88.8% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2477   +/-   ##
=====================================
  Coverage   77.1%   77.2%           
=====================================
  Files        124     124           
  Lines      23021   23051   +30     
=====================================
+ Hits       17771   17800   +29     
- Misses      5250    5251    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas closed this Dec 26, 2024
@cijothomas cijothomas reopened this Dec 26, 2024
@utpilla utpilla merged commit e378bc8 into open-telemetry:main Dec 26, 2024
35 of 39 checks passed
@cijothomas cijothomas deleted the cijothomas/periodicreader-shutdownfix branch December 26, 2024 23:38
adriangb pushed a commit to adriangb/opentelemetry-rust that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants