Skip to content

Conversation

@cijothomas
Copy link
Member

No description provided.

@cijothomas cijothomas requested a review from a team as a code owner December 27, 2024 00:49
@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (d52fec7) to head (31a6bf6).
Report is 211 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/exporter.rs 66.6% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2479   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        123     124    +1     
  Lines      22864   22846   -18     
=====================================
- Hits       17800   17794    -6     
+ Misses      5064    5052   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should require exporter author to think through the expected behavior rather than have a blank implementation. The benifit I see is we reduce some duplication in our code base.

Also adding a default implemtation is not breaking change but removing the default implementation is. Thus I prefer to not add default implemtation. Overall I don't think the benifit is worth the risk

@cijothomas
Copy link
Member Author

Closing inactive PRs. This can be discussed via an issue.

@cijothomas cijothomas closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants