-
Notifications
You must be signed in to change notification settings - Fork 600
Update metrics benchmarks #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics benchmarks #2502
Conversation
| &[ | ||
| KeyValue::new( | ||
| "attribute1", | ||
| attribute_values[index_first_attribute].as_str().to_owned(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #2089, we would be able to simply pass a string slice and avoid the string allocation:
| attribute_values[index_first_attribute].as_str().to_owned(), | |
| attribute_values[index_first_attribute].as_str(), |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 123 123
Lines 22888 22888
=====================================
Hits 17839 17839
Misses 5049 5049 ☔ View full report in Codecov by Sentry. |
Changes
iter_batchedto exclude the setup time from the measurement. Similar to what Exclude benchmark setup duration using iter_batched #2233 did for CounterMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes