Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Jan 17, 2025

Changes

  • The full log validation test runs sequentially, and the logs.json is cleaned-up before running
  • Rest of the tests run in parallel.
  • Some nit cleanup of method for reusability.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner January 17, 2025 18:40
@lalitb lalitb added the integration tests Run integration tests label Jan 17, 2025
@lalitb lalitb mentioned this pull request Jan 17, 2025
4 tasks
@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (68af3bb) to head (212c29c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2525   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22944   22944           
=====================================
  Hits       17880   17880           
  Misses      5064    5064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Jan 21, 2025

Removed the use of serial_test crate, to minimize external crate dependency. The full log validation test runs isolated from the rest of the tests by moving it to separate binary.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cijothomas cijothomas merged commit 78db32c into open-telemetry:main Jan 21, 2025
21 checks passed
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration tests Run integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants