Skip to content

Conversation

@cijothomas
Copy link
Member

Opening to get some early feedback.
Trying to consistently follow:
otel_sdk::signal(logs/metrics/trace)::component

so instead of opentelemetry_sdk::export::logs::{ExportResult, LogBatch, LogExporter}
we have opentelemetry_sdk::logs::{ExportResult, LogBatch, LogExporter}

(Haven't done changes to other crates. Will proceed once I get some feedback. These are breaking changes, and we need to do it before stable.)

@lalitb
Copy link
Member

lalitb commented Jan 22, 2025

Just to be more explicit, we are discussing to have single level of namespace indirection as below:
otel_sdk::logs/metrics/trace/resource/propagator::component

+1 to the approach

@ThomsonTan
Copy link
Contributor

Just to be more explicit, we are discussing to have single level of namespace indirection as below: otel_sdk::logs/metrics/trace/resource/propagator::component

+1 to the approach

Does otel_sdk::logs work? It is even shorter than opentelemetry_sdk::logs and also, it implies it is kind of short name and differentiate it from the full form of opentelemetry_logs::....

@cijothomas
Copy link
Member Author

Just to be more explicit, we are discussing to have single level of namespace indirection as below: otel_sdk::logs/metrics/trace/resource/propagator::component

+1 to the approach

Yes.
Another example one I am about to send PR for is - testing::logs::InMemoryLogExporterBuilder -> logs::testing::InMemoryLogExporter

@cijothomas cijothomas marked this pull request as ready for review January 23, 2025 00:19
@cijothomas cijothomas requested a review from a team as a code owner January 23, 2025 00:19
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (b1debf0) to head (57ce632).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2534   +/-   ##
=====================================
  Coverage   77.7%   77.7%           
=====================================
  Files        123     123           
  Lines      23057   23057           
=====================================
  Hits       17938   17938           
  Misses      5119    5119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

Just to be more explicit, we are discussing to have single level of namespace indirection as below: otel_sdk::logs/metrics/trace/resource/propagator::component
+1 to the approach

Does otel_sdk::logs work? It is even shorter than opentelemetry_sdk::logs and also, it implies it is kind of short name and differentiate it from the full form of opentelemetry_logs::....

opentelemetry_sdk is coming from the crate name, so I don't think we can (or should) change it.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

opentelemetry_sdk::logs::log_processor_with_async_runtime will remain in multi-namespace redirection - perhaps would be difficult to fix without changing processor name.

@cijothomas cijothomas merged commit 57d1297 into open-telemetry:main Jan 23, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/refactor-log-mod branch January 23, 2025 00:50
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants