-
Notifications
You must be signed in to change notification settings - Fork 600
Refactor LogExporter mod #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LogExporter mod #2534
Conversation
|
Just to be more explicit, we are discussing to have single level of namespace indirection as below: +1 to the approach |
Does |
Yes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 123 123
Lines 23057 23057
=====================================
Hits 17938 17938
Misses 5119 5119 ☔ View full report in Codecov by Sentry. |
|
lalitb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
opentelemetry_sdk::logs::log_processor_with_async_runtime will remain in multi-namespace redirection - perhaps would be difficult to fix without changing processor name.
Opening to get some early feedback.
Trying to consistently follow:
otel_sdk::signal(logs/metrics/trace)::component
so instead of
opentelemetry_sdk::export::logs::{ExportResult, LogBatch, LogExporter}we have
opentelemetry_sdk::logs::{ExportResult, LogBatch, LogExporter}(Haven't done changes to other crates. Will proceed once I get some feedback. These are breaking changes, and we need to do it before stable.)