Skip to content

Conversation

@cijothomas
Copy link
Member

Minor change, also few nit doc updates.
Such get() methods typically only requires ref, so modified Resource::get to also match that.

@cijothomas cijothomas requested a review from a team as a code owner January 24, 2025 15:30
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (4f472a8) to head (15d18a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-zipkin/src/exporter/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2552   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        122     122           
  Lines      23055   23058    +3     
=====================================
+ Hits       17952   17955    +3     
  Misses      5103    5103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 14faca3 into open-telemetry:main Jan 24, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/resourcekeyref branch January 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants