Skip to content

Conversation

@Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Feb 2, 2025

Changes

This PR modifies some problems in the sample code on README 😸 :

  • TracerProvider in v0.22 doesn't have shutdown() method. We should use v0.27 (the latest version) instead
  • opentelemetry::global is no longer used since 6d1a765
  • opentelemetry-stdout v0.3 is outdated. It's SpanExporter doesn't satisfy with_simple_exporter()'s requirement

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

- v0.27 is the latest version
- TracerProvider in v0.22 doesn't have shutdown() method
- opentelemetry::global is no longer used
- opentelemetry-stdout v0.3 is staled. It's exporter SpanExporter doesn't satisfy with_simple_exporter()'s requirement

Signed-off-by: Shunpoco <[email protected]>
@Shunpoco Shunpoco requested a review from a team as a code owner February 2, 2025 12:09
@codecov
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (a1860eb) to head (8ab6018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2585   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        118     118           
  Lines      22490   22490           
=====================================
  Hits       17888   17888           
  Misses      4602    4602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shunpoco Shunpoco changed the title [WIP] Version up Cargo.toml on README.md Version up sample code/Cargo.toml on README.md Feb 2, 2025
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cijothomas cijothomas merged commit 8c5daa2 into open-telemetry:main Feb 2, 2025
21 checks passed
@Shunpoco Shunpoco deleted the fix-readme-version branch February 2, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants