Assert explicitly that shutdown succeeded in Integration tests #2605
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
=====================================
Coverage 79.2% 79.2%
=====================================
Files 118 118
Lines 22513 22513
=====================================
Hits 17831 17831
Misses 4682 4682 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Feb 4, 2025
|
|
||
| // In tokio::current_thread flavor, shutdown must be done in a separate thread | ||
| let _res = Handle::current() | ||
| let shutdown_resut = Handle::current() |
Member
There was a problem hiding this comment.
nit shutdown_result all the places.
lalitb
approved these changes
Feb 4, 2025
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes