Skip to content

Conversation

@cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner February 5, 2025 19:26
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (1fbaaf2) to head (2c8d018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2619     +/-   ##
=======================================
- Coverage   79.0%   79.0%   -0.1%     
=======================================
  Files        119     119             
  Lines      22531   22534      +3     
=======================================
- Hits       17819   17818      -1     
- Misses      4712    4716      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing this. seems got introduced by my one of my PR :(

@cijothomas cijothomas merged commit ad38303 into open-telemetry:main Feb 5, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/buildfix branch February 5, 2025 21:01
@cijothomas
Copy link
Member Author

Thank for fixing this. seems got introduced by my one of my PR :(

Our CI runs with all feature flags. We can probably do another build with just default features to help catch these in CI

bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants