Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 13, 2025

Relates #2517

Changes

  • also removed unused dependencies in sdk and stdout
  • also migrated LogExporterWithFuture in the sdk bench to native async trait

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 13, 2025 20:51
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (1aca212) to head (662d36f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2662     +/-   ##
=======================================
- Coverage   79.1%   79.1%   -0.1%     
=======================================
  Files        120     120             
  Lines      22556   22562      +6     
=======================================
+ Hits       17857   17861      +4     
- Misses      4699    4701      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lalitb lalitb merged commit 00ebc98 into open-telemetry:main Feb 14, 2025
21 checks passed
@gruebel gruebel deleted the remove-async-trait branch February 14, 2025 06:33
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Feb 18, 2025
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants