-
Notifications
You must be signed in to change notification settings - Fork 600
Add Scott Gerring as an Approver #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scott Gerring as an Approver #2679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
=====================================
Coverage 79.2% 79.2%
=====================================
Files 123 123
Lines 22572 22572
=====================================
Hits 17885 17885
Misses 4687 4687 ☔ View full report in Codecov by Sentry. |
|
Agreed. The number of PRs isn’t a concern - he’s been actively driving efforts to clarify the ambiguity around some of the important design and implementation decisions, which is crucial. His work should definitely take priority. |
|
Just realized that the guideline says reviewer or author; hence, not an issue!
|
|
Are we waiting on more approvals? |
I'd leave it open for 2 days to let other maintainers/approvers get a chance to review. If no objections, will merge tomorow. |
|
Added @scottgerring to @open-telemetry/rust-approvers group. Welcome! |
I'd like to nominate @scottgerring as an Approver for the project. He has been helping with reviews/contributions for the last 2-3 months, and has expressed willingness to continue to help drive the project forward.
https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#requirements-2
The "at least 10 substantial PRs" is not met, (?) largely due to others (including me) taking over implementing the PRs, after Scott helped drive design consensus. Happy to discuss more if there are concerns about not strictly meeting the "10 PR requirement.".
Edit: This is not an issue