Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Feb 18, 2025

I'd like to nominate @scottgerring as an Approver for the project. He has been helping with reviews/contributions for the last 2-3 months, and has expressed willingness to continue to help drive the project forward.

https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#requirements-2
The "at least 10 substantial PRs" is not met, (?) largely due to others (including me) taking over implementing the PRs, after Scott helped drive design consensus. Happy to discuss more if there are concerns about not strictly meeting the "10 PR requirement.".

Edit: This is not an issue

@cijothomas cijothomas requested a review from a team as a code owner February 18, 2025 19:19
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (a70affd) to head (105a46d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2679   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        123     123           
  Lines      22572   22572           
=====================================
  Hits       17885   17885           
  Misses      4687    4687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Feb 18, 2025

Agreed. The number of PRs isn’t a concern - he’s been actively driving efforts to clarify the ambiguity around some of the important design and implementation decisions, which is crucial. His work should definitely take priority.

@cijothomas
Copy link
Member Author

cijothomas commented Feb 18, 2025

Just realized that the guideline says reviewer or author; hence, not an issue!

"Reviewer for or author of at least 10 substantial PRs "

@TommyCpp
Copy link
Contributor

Are we waiting on more approvals?

@cijothomas
Copy link
Member Author

Are we waiting on more approvals?

I'd leave it open for 2 days to let other maintainers/approvers get a chance to review. If no objections, will merge tomorow.

@cijothomas cijothomas merged commit cb81eb6 into open-telemetry:main Feb 21, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/addscott-approver branch February 21, 2025 15:07
@cijothomas
Copy link
Member Author

Added @scottgerring to @open-telemetry/rust-approvers group. Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants