update rand dependency #2681
Merged
update rand dependency #2681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
=======================================
- Coverage 79.1% 79.1% -0.1%
=======================================
Files 122 122
Lines 22546 22543 -3
=======================================
- Hits 17853 17850 -3
Misses 4693 4693 ☔ View full report in Codecov by Sentry. |
TommyCpp
reviewed
Feb 19, 2025
| futures-util = { workspace = true, features = ["std", "sink", "async-await-macro"] } | ||
| percent-encoding = { version = "2.0", optional = true } | ||
| rand = { workspace = true, features = ["std", "std_rng","small_rng"], optional = true } | ||
| rand = { workspace = true, features = ["std", "std_rng", "small_rng", "os_rng", "thread_rng"], optional = true } |
Contributor
There was a problem hiding this comment.
I see we actually removed thread_rng in other files. Why do we still need this feature?
Member
Author
There was a problem hiding this comment.
it was just renamed, thread_rng() -> rng()
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rand, mostly renamed methodsMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes