Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Feb 20, 2025

Changes

  • streamlining the native async trait implementation

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 20, 2025 20:59
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (37efb88) to head (328e847).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 0.0% 2 Missing ⚠️
...y-sdk/src/logs/log_processor_with_async_runtime.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2692   +/-   ##
=====================================
  Coverage   79.2%   79.3%           
=====================================
  Files        123     123           
  Lines      22612   22602   -10     
=====================================
- Hits       17931   17927    -4     
+ Misses      4681    4675    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cijothomas cijothomas merged commit 5ce50ae into open-telemetry:main Feb 20, 2025
20 of 21 checks passed
@gruebel gruebel deleted the remove-async-move branch February 25, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants