InstrumentationScope to include attributes in hash and eq check #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
=====================================
Coverage 79.2% 79.3%
=====================================
Files 123 123
Lines 22582 22657 +75
=====================================
+ Hits 17899 17974 +75
Misses 4683 4683 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Feb 21, 2025
| let _meter2 = | ||
| meter_provider.meter_with_scope(make_scope(vec![KeyValue::new("key", "value1")])); | ||
|
|
||
| assert_eq!(meter_provider.inner.meters.lock().unwrap().len(), 1); |
Member
There was a problem hiding this comment.
nit - add test with different attributes, just to ensure that existing behavior is not affected.
Member
Author
There was a problem hiding this comment.
#2702 Yes there are various combinations that need to have good coverage. Opening an issue to track them overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2225
For Metrics this affects aggregation (SDK), as now different Meter is returned for scope with different attributes.
Logs,Traces do not store Logger/Tracers, so this requires no change in SDKs.