chore: Prevent libtest being added to bench builds #2705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change sets us up to be able to run criterion performance regressions as part of the CI suite, annotating the PR with the results. As we've invested time into doing the performance tests, it would be great to be able to use them to monitor performance changes, and this is a relatively simple job.
I reckon this will also be helpful in the context of #2378 , where @bantonsson has spent some time demonstrating this his new Context impl is faster than the previous.
The change is split into two:
You can see what this looks like in action over in the faked up PR => scotts-test-organization#1
Without the first PR, the second PRs workflow will not succeed.
Details
To run criterion with additional CLI arguments across an entire crate at once - not just
--bench my_bench- we need to stoplibtestbeing added to the targets of the crates that contain benches. This is discussed in the criterion FAQ.This change allows you to run the following for each of the crates we publish with
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes