Skip to content

Conversation

@scottgerring
Copy link
Member

#2706 turns benchmarks on in the CI build. The bench in this PR fails intermittently. This comments it out to keep the build going smoothly so we can fix it async.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (261ac75) to head (7325ef3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2712   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22670   22670           
=====================================
  Hits       17986   17986           
  Misses      4684    4684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring marked this pull request as ready for review February 26, 2025 08:52
@scottgerring scottgerring requested a review from a team as a code owner February 26, 2025 08:52
@scottgerring scottgerring marked this pull request as draft February 26, 2025 08:54
@scottgerring scottgerring marked this pull request as ready for review February 26, 2025 10:15
@scottgerring scottgerring changed the title test: comment out intermittent failing assertion chore: comment out intermittent failing assertion Feb 26, 2025
@scottgerring scottgerring marked this pull request as draft February 26, 2025 11:11
@scottgerring scottgerring deleted the chore/comment-assert branch February 26, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant