Skip to content

Conversation

@bantonsson
Copy link
Contributor

Changes

Fixes small nits from #2707 and removes the Throughput settings in the benchmarks since the benchmark action doesn't seem to parse that properly.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson requested a review from a team as a code owner February 26, 2025 11:05
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (261ac75) to head (a14c874).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2713   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22670   22670           
=====================================
+ Hits       17986   17987    +1     
+ Misses      4684    4683    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring
Copy link
Member

Looks good to me, and as discussed, I think the timings tell the whole story and we don't need the throughput anyhow. I commented on an existing issue over on the github action that captures the parsing issue too.

@cijothomas cijothomas merged commit f9ccdff into open-telemetry:main Feb 26, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants