Skip to content

Conversation

@paullegranddc
Copy link
Contributor

I like to run cargo test --workspace --all-features to run all tests in a workspace. This is currently failing:

  • Running otlp logger integration tests with reqwest-blocking-client and the default features in the integration_test_runner package are failing two of the tests are not compatible with having both reqwest-blocking-client and tonic-client enabled at the same time.
  • Running otlp logger integration tests with experimental_metadata_attributes fails because of the extra attributes added to logs do not match the snapshot.

Changes

  • Skip tests on incompatible features
  • Remove extra attributes before doing the snapshot comparison if the experimental_metadata_attributes flag is set

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@paullegranddc paullegranddc requested a review from a team as a code owner March 11, 2025 16:59
@paullegranddc paullegranddc changed the title tests: fix otlp logger tests failing with some set of features tests: fix otlp log integrtaion tests failing with some set of features Mar 11, 2025
@paullegranddc paullegranddc changed the title tests: fix otlp log integrtaion tests failing with some set of features tests: fix otlp log integration tests failing with some set of features Mar 11, 2025
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (dac8bd5) to head (07efe62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2784   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        123     123           
  Lines      23117   23117           
=====================================
  Hits       18428   18428           
  Misses      4689    4689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

feature = "reqwest-client"
))]
pub fn logs_simple_non_tokio_main_with_init_logs_outsie_rt() -> Result<()> {
pub fn logs_simple_non_tokio_main_with_init_logs_outside_rt() -> Result<()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paullegranddc paullegranddc changed the title tests: fix otlp log integration tests failing with some set of features test: fix otlp log integration tests failing with some set of features Mar 11, 2025
@cijothomas cijothomas merged commit 51dda2f into open-telemetry:main Mar 11, 2025
23 of 26 checks passed
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants