perf: Inline enabled check in Logger #2823
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
=====================================
Coverage 79.7% 79.7%
=====================================
Files 124 124
Lines 23297 23297
=====================================
Hits 18582 18582
Misses 4715 4715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shivanshuraj1333
approved these changes
Mar 18, 2025
utpilla
reviewed
Mar 18, 2025
| |---------------------------------------------|-------------| | ||
| | exporter_disabled_concurrent_processor | 1.9 ns | | ||
| | exporter_disabled_simple_processor | 5.0 ns | | ||
| | exporter_disabled_concurrent_processor | 1.0 ns | |
Contributor
There was a problem hiding this comment.
Add the inline attribute to the processor and exporter's event_enabled methods as well?
Member
Author
There was a problem hiding this comment.
I tried that but it didn't give any boost 🤷♂️
lalitb
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good boost to the enabled() check.