Skip to content

perf: LogEnabled inline more #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utpilla merged 1 commit into from
Mar 18, 2025
Merged

perf: LogEnabled inline more #2828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions opentelemetry-sdk/benches/log_enabled.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
Total Number of Cores:   14 (10 performance and 4 efficiency)
| Test | Average time|
|---------------------------------------------|-------------|
| exporter_disabled_concurrent_processor | 1.0 ns |
| exporter_disabled_simple_processor | 4.5 ns |
| exporter_disabled_concurrent_processor | 980 ps |
| exporter_disabled_simple_processor | 4.3 ns |
*/

// cargo bench --bench log_enabled --features="spec_unstable_logs_enabled,experimental_logs_concurrent_log_processor"
Expand All @@ -33,6 +33,7 @@ impl LogExporter for NoopExporter {
Ok(())
}

#[inline]
fn event_enabled(
&self,
_level: opentelemetry::logs::Severity,
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/logs/concurrent_log_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ impl<T: LogExporter> LogProcessor for SimpleConcurrentLogProcessor<T> {
}

#[cfg(feature = "spec_unstable_logs_enabled")]
#[inline]
fn event_enabled(
&self,
level: opentelemetry::logs::Severity,
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/logs/simple_log_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ impl<T: LogExporter> LogProcessor for SimpleLogProcessor<T> {
}

#[cfg(feature = "spec_unstable_logs_enabled")]
#[inline]
fn event_enabled(
&self,
level: opentelemetry::logs::Severity,
Expand Down