Skip to content

Conversation

@bantonsson
Copy link
Contributor

Changes

Runs all the benchmarks in one single action. It also removes all feature flags from the github action and relies on the features defined in the Cargo.toml files. This ensure that no benchmarks are skipped accidentally.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson requested a review from a team as a code owner March 31, 2025 07:21
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1%. Comparing base (d5e409c) to head (36b2494).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2885     +/-   ##
=======================================
- Coverage   81.1%   81.1%   -0.1%     
=======================================
  Files        124     124             
  Lines      23927   23927             
=======================================
- Hits       19411   19406      -5     
- Misses      4516    4521      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring
Copy link
Member

scottgerring commented Mar 31, 2025

This'll make it easier to use a jazzier benchmark process (e.g., to publish to pages, like otel collector does) as well. No brainer to approve once we've seen it run through successfully once and checked that we've got the same set of benches running.

@bantonsson
Copy link
Contributor Author

Same time and same number of benchmarks (168).

Copy link
Member

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight to prod

@cijothomas
Copy link
Member

:shipit:

@cijothomas cijothomas merged commit 867e2a1 into open-telemetry:main Mar 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants