feat: add shutdown with timeout for metric reader and provider #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2890 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 125 126 +1
Lines 24134 24143 +9
=====================================
+ Hits 19630 19640 +10
+ Misses 4504 4503 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
reviewed
Apr 6, 2025
| Custom exporters will need to internally synchronize any mutable state, if applicable. | ||
|
|
||
| - **Breaking** The `shutdown_with_timeout` method is added to MetricExporter trait. This is breaking change for custom `MetricExporter` authors. | ||
| - **Breaking** The `shutdown_with_timeout` method is added to MetricReader trait. This is breaking change for custom `MetricReader` authors. |
Member
There was a problem hiding this comment.
this should be in vnext section
cijothomas
approved these changes
Apr 6, 2025
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
LGTM, need to move changelog entry to the unreleased part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2574 Part 2: Adding shutdown_with_timeout for metric reader and provider