Skip to content

chore: fix clippy lint errors for rust 1.86.0 #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 1 commit into from
Apr 3, 2025
Merged

chore: fix clippy lint errors for rust 1.86.0 #2896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opentelemetry-sdk/src/metrics/instrument.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@

/// empty returns if all fields of i are their default-value.
pub(crate) fn is_empty(&self) -> bool {
self.name == ""
&& self.description == ""
self.name.is_empty()
&& self.description.is_empty()

Check warning on line 134 in opentelemetry-sdk/src/metrics/instrument.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-sdk/src/metrics/instrument.rs#L134 

Added line #L134 was not covered by tests
&& self.kind.is_none()
&& self.unit == ""
&& self.unit.is_empty()

Check warning on line 136 in opentelemetry-sdk/src/metrics/instrument.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-sdk/src/metrics/instrument.rs#L136 

Added line #L136 was not covered by tests
&& self.scope == InstrumentationScope::default()
}

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/metrics/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ pub fn new_view(criteria: Instrument, mask: Stream) -> MetricResult<Box<dyn View
let contains_wildcard = criteria.name.contains(['*', '?']);

let match_fn: Box<dyn Fn(&Instrument) -> bool + Send + Sync> = if contains_wildcard {
if mask.name != "" {
if !mask.name.is_empty() {
// TODO - The error is getting lost here. Need to return or log.
return Ok(Box::new(empty_view));
}
Expand Down
Loading