Skip to content

Conversation

@bantonsson
Copy link
Contributor

Changes

This adds the ability to add a Link to a Span via a SpanRef. Since you can only access a SpanRef from the current Context, there was no way to add a new Link to that span.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson requested a review from a team as a code owner May 6, 2025 14:48
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (1d9bd25) to head (650384f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2959     +/-   ##
=======================================
+ Coverage   81.3%   81.4%   +0.1%     
=======================================
  Files        126     126             
  Lines      24289   24305     +16     
=======================================
+ Hits       19763   19808     +45     
+ Misses      4526    4497     -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nit: add a changelog entry too as this is user facing addition!

@cijothomas cijothomas merged commit f771404 into open-telemetry:main May 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants