fix: PeriodicReader to reuse data structures across collect #2963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
=====================================
Coverage 81.4% 81.5%
=====================================
Files 126 126
Lines 24305 24303 -2
=====================================
+ Hits 19808 19816 +8
+ Misses 4497 4487 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hdost
force-pushed
the
cijothomas/reuse-metric
branch
from
2e1b749 to
9a785be
Compare
hdost
approved these changes
May 14, 2025
Contributor
hdost
left a comment
hdost
left a comment
There was a problem hiding this comment.
Please fix the lint otherwise good 👍
utpilla
reviewed
May 14, 2025
| fn collect_and_export(&self, rm: &mut ResourceMetrics) -> OTelSdkResult { | ||
| let current_time = Instant::now(); | ||
| let collect_result = self.collect(&mut rm); | ||
| let collect_result = self.collect(rm); |
Contributor
There was a problem hiding this comment.
I guess this still works without the need to clear the scope_metrics vec within the ResourceMetrics. I'm not sure if we have tests for this already but we need to ensure that clearing is not required by verifying that subsequent collects don't continue to show the old data from the previous collect (in case of Delta).
utpilla
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodicReader was unnecessarily creating a new empty
ResourceMetricsduring every collect. This PR modifies periodic reader to create once at startup, and re-use it throughout. Of course, the actual contents change for each collect, but the backing arrays for vectors will be re-used.