Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented May 14, 2025

Changes

  • Update public APIs for Resource Metrics

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla changed the title fix: Update ResourceMetrics fix: Update ResourceMetrics public API May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (82e5ed4) to head (1af8306).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/data/mod.rs 0.0% 15 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 9 Missing ⚠️
opentelemetry-proto/src/transform/metrics.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2965     +/-   ##
=======================================
- Coverage   81.5%   81.4%   -0.1%     
=======================================
  Files        126     126             
  Lines      24303   24319     +16     
=======================================
- Hits       19816   19812      -4     
- Misses      4487    4507     +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@utpilla utpilla marked this pull request as ready for review May 14, 2025 07:15
@utpilla utpilla requested a review from a team as a code owner May 14, 2025 07:15
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cijothomas cijothomas merged commit a4575af into open-telemetry:main May 14, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants