Skip to content

Conversation

@paullegranddc
Copy link
Contributor

Fixes #
Design discussion issue (if applicable) #

Changes

Dependencies resolved while running the external-types in the PR are not compatible with the version of rust used to run the check. The steps have been failing on main for a while.

This PR adds a pass to patch the Cargo.lock file, as is done in the msrv check.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@paullegranddc paullegranddc requested a review from a team as a code owner May 14, 2025 13:31
@paullegranddc paullegranddc changed the title fix: patch dependencies because of semver issues fix(CI): patch dependencies before running external-types check May 14, 2025
@cijothomas cijothomas merged commit 8fe3dcc into open-telemetry:main May 14, 2025
26 checks passed
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (3f29f6d) to head (390ba3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2967   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        126     126           
  Lines      24305   24305           
=====================================
  Hits       19808   19808           
  Misses      4497    4497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants