Skip to content

Conversation

@cijothomas
Copy link
Member

Leftover cleanup from #2988

View trait itself is not required to be public - no functionality change.
Plus few other leftover nits from PR comments earlier.

@cijothomas cijothomas requested a review from a team as a code owner May 22, 2025 00:53
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (e123996) to head (3712a18).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 50.0% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2989   +/-   ##
=====================================
  Coverage   81.3%   81.4%           
=====================================
  Files        126     126           
  Lines      24570   24573    +3     
=====================================
+ Hits       19996   20004    +8     
+ Misses      4574    4569    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit ebbebf5 into open-telemetry:main May 22, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants