Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented May 22, 2025

We previously hid the implementation details (eg: Vec!), and exposed getter returning slices. To ensure consistency, this PR changes all fields to be accessible via getter methods only.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 150 lines in your changes missing coverage. Please review.

Project coverage is 81.1%. Comparing base (4be1a32) to head (45708ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/data/mod.rs 0.0% 96 Missing ⚠️
opentelemetry-proto/src/transform/metrics.rs 0.0% 32 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 22 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2997     +/-   ##
=======================================
- Coverage   81.5%   81.1%   -0.4%     
=======================================
  Files        126     126             
  Lines      24698   24794     +96     
=======================================
- Hits       20131   20130      -1     
- Misses      4567    4664     +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas changed the title Remove pub fields and replace with getter method consistently across … fix: Remove pub fields and replace with getter method consistently across … May 22, 2025
@cijothomas cijothomas marked this pull request as ready for review May 23, 2025 00:36
@cijothomas cijothomas requested a review from a team as a code owner May 23, 2025 00:36
@utpilla utpilla merged commit bf22aeb into open-telemetry:main May 23, 2025
26 of 27 checks passed
@cijothomas cijothomas deleted the cijothomas/metrics-pub branch May 23, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants