Skip to content

fix: add panic error when multiple HTTP features are enabled #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add panic error when multiple HTTP features are enabled #3003

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0362502
add panic error when multiple HTTP features are enabled
gruebel May 23, 2025
08cfa6c
change to normal error
gruebel May 25, 2025
5ba7a84
Update opentelemetry-otlp/src/exporter/http/mod.rs
gruebel May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions opentelemetry-otlp/src/exporter/http/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,14 @@ impl HttpExporterBuilder {
.unwrap(), // TODO: Return ExporterBuildError::ThreadSpawnFailed
) as Arc<dyn HttpClient>);
}
#[cfg(any(
all(feature = "hyper-client", feature = "reqwest-client"),
all(feature = "hyper-client", feature = "reqwest-blocking-client"),
all(feature = "reqwest-client", feature = "reqwest-blocking-client")
))]
{
panic!("Can't enable more than one HTTP client features simultaneously. Please choose only one: hyper-client, reqwest-client, or reqwest-blocking-client (default feature)");
}
}

let http_client = http_client.ok_or(ExporterBuildError::NoHttpClient)?;
Expand Down Expand Up @@ -741,4 +749,20 @@ mod tests {
assert_eq!(url, "http://localhost:4318/v1/tracesbutnotreally");
});
}

#[cfg(any(
all(feature = "hyper-client", feature = "reqwest-client"),
all(feature = "hyper-client", feature = "reqwest-blocking-client"),
all(feature = "reqwest-client", feature = "reqwest-blocking-client")
))]
#[test]
#[should_panic(expected = "Can't enable more than one HTTP client features simultaneously.")]
fn test_http_exporter_builder_panics_with_multiple_http_features() {
let mut builder = HttpExporterBuilder {
http_config: HttpConfig::default(),
exporter_config: crate::ExportConfig::default(),
};

let _ = builder.build_client("ENV_VAR_1", "PATH", "ENV_VAR_2", "ENV_VAR_3");
}
}