chore: opentelemetry-appender-log set_observed_timestamp #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
=====================================
Coverage 81.0% 81.0%
=====================================
Files 126 126
Lines 24753 24754 +1
=====================================
+ Hits 20070 20071 +1
Misses 4683 4683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
reviewed
May 27, 2025
| fn log(&self, record: &Record) { | ||
| if self.enabled(record.metadata()) { | ||
| let mut log_record = self.logger.create_log_record(); | ||
| log_record.set_observed_timestamp(std::time::SystemTime::now()); |
Member
There was a problem hiding this comment.
This is already set correctly in the SDK Implementation, so no need to set it from the appenders. Is there any advantage this should be set from the appender itself?
Contributor
Author
There was a problem hiding this comment.
Good to know. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convey some experience in https://github.com/fast/logforth/blob/243650c342d1b2bfae98381212430b4467d8bac5/src/append/opentelemetry.rs#L222