Skip to content

Conversation

@cijothomas
Copy link
Member

Small improvements I found useful from OTLP testing.

@cijothomas cijothomas requested a review from a team as a code owner May 27, 2025 22:43
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 80.9%. Comparing base (167c946) to head (91c576c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/http/metrics.rs 0.0% 18 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 10 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/metrics.rs 0.0% 10 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/trace.rs 0.0% 10 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 4 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3007     +/-   ##
=======================================
- Coverage   81.0%   80.9%   -0.2%     
=======================================
  Files        126     126             
  Lines      24755   24787     +32     
=======================================
  Hits       20072   20072             
- Misses      4683    4715     +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Ok(())
}
Err(e) => {
let error = format!("export error: {:?}", e);
Copy link
Contributor

@utpilla utpilla May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do something similar to what you have for the Http clients which is using the error/status code and message/response:

Suggested change
let error = format!("export error: {:?}", e);
let error = format!(
"OpenTelemetry logs export failed. Status Code: {}, Message: {:?}",
e.code(),
e.message()
);

@cijothomas cijothomas merged commit 6279060 into open-telemetry:main May 30, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants