Skip to content

chore: update tonic and prost to 0.14 #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acrrd
Copy link

@acrrd acrrd commented Jul 31, 2025

Changes

update tonic to 0.14.1 (we need the .1 to avoid msrv bump)
prost to 0.14.
tonic split out prost code to tonic-prost and tonic-prost-build.

it bump msrv of -otlp and -proto crates to 1.86.0 because of the same bump in tonic.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@acrrd acrrd requested a review from a team as a code owner July 31, 2025 13:53
Copy link

linux-foundation-easycla bot commented Jul 31, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.4%. Comparing base (86dfd4b) to head (68127d5).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3093     +/-   ##
=======================================
- Coverage   80.4%   80.4%   -0.1%     
=======================================
  Files        126     126             
  Lines      22237   22237             
=======================================
- Hits       17898   17894      -4     
- Misses      4339    4343      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acrrd acrrd force-pushed the update_tonic_prost_0.14 branch 2 times, most recently from 53de9a7 to 5f50ac2 Compare July 31, 2025 14:42
@acrrd
Copy link
Author

acrrd commented Jul 31, 2025

atm this is incompatible with the msrv policy that requires to support stable - 3 releases. fortunately a new release will be available on the 7th of August.

@acrrd acrrd force-pushed the update_tonic_prost_0.14 branch 2 times, most recently from 8778341 to bb4851b Compare July 31, 2025 15:05
@cijothomas
Copy link
Member

it bump msrv of -otlp and -proto crates to 1.86.0 because of the same bump in tonic.

https://github.com/hyperium/tonic?tab=readme-ov-file#rust-version states 1.75.

@acrrd
Copy link
Author

acrrd commented Aug 5, 2025

it bump msrv of -otlp and -proto crates to 1.86.0 because of the same bump in tonic.

https://github.com/hyperium/tonic?tab=readme-ov-file#rust-version states 1.75.

In Cargo.toml 1.86 is specified and that's why cargo machete fails
https://github.com/hyperium/tonic/blob/edd281b6b562101fa2a04742879713006d7bb360/Cargo.toml#L32

@cijothomas
Copy link
Member

it bump msrv of -otlp and -proto crates to 1.86.0 because of the same bump in tonic.

https://github.com/hyperium/tonic?tab=readme-ov-file#rust-version states 1.75.

In Cargo.toml 1.86 is specified and that's why cargo machete fails https://github.com/hyperium/tonic/blob/edd281b6b562101fa2a04742879713006d7bb360/Cargo.toml#L32

Got it. It looks like that was not intentional, as I see an issue opened for it - hyperium/tonic#2361

@acrrd
Copy link
Author

acrrd commented Aug 6, 2025

I see, I'll update this once tonic 0.14.1 is out

@acrrd
Copy link
Author

acrrd commented Aug 6, 2025

Some bump will be necessary anyway. Do you prefer to keep it confined to just the crates that are involved like now or we bump all of them?

@cijothomas
Copy link
Member

Some bump will be necessary anyway. Do you prefer to keep it confined to just the crates that are involved like now or we bump all of them?

Let's wait to see how much we have to bump MSRV. Generally we prefer to bump OTLP only, as that's the only one needing tonic etc., so no need to force bump all crates.

@acrrd acrrd force-pushed the update_tonic_prost_0.14 branch from 1c9daee to 68127d5 Compare August 8, 2025 13:25
@acrrd
Copy link
Author

acrrd commented Aug 8, 2025

@cijothomas no bump needed!

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants