-
Notifications
You must be signed in to change notification settings - Fork 557
chore: update tonic and prost to 0.14 #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
=======================================
- Coverage 80.4% 80.4% -0.1%
=======================================
Files 126 126
Lines 22237 22237
=======================================
- Hits 17898 17894 -4
- Misses 4339 4343 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53de9a7
to
5f50ac2
Compare
atm this is incompatible with the msrv policy that requires to support stable - 3 releases. fortunately a new release will be available on the 7th of August. |
8778341
to
bb4851b
Compare
https://github.com/hyperium/tonic?tab=readme-ov-file#rust-version states 1.75. |
In Cargo.toml 1.86 is specified and that's why |
Got it. It looks like that was not intentional, as I see an issue opened for it - hyperium/tonic#2361 |
I see, I'll update this once tonic 0.14.1 is out |
Some bump will be necessary anyway. Do you prefer to keep it confined to just the crates that are involved like now or we bump all of them? |
Let's wait to see how much we have to bump MSRV. Generally we prefer to bump OTLP only, as that's the only one needing tonic etc., so no need to force bump all crates. |
1c9daee
to
68127d5
Compare
@cijothomas no bump needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the upgrade
Changes
update tonic to 0.14.1 (we need the .1 to avoid msrv bump)
prost to 0.14.
tonic split out prost code to tonic-prost and tonic-prost-build.
it bump msrv of -otlp and -proto crates to 1.86.0 because of the same bump in tonic.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes