Remove unnecessary serde_json dependency from logs feature #3106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logsfeature inopentelemetry-sdkwas incorrectly includingserde_jsonas a dependency, which is not needed for basic logs functionality. This was causing unnecessary bloat for users who only want logging capabilities without JSON serialization.Changes Made
Removed
serde_jsonfrom logs feature: Updated the feature definition inCargo.tomlfrom:to:
Fixed deprecated API usage in tests: Updated test code to use current APIs:
TraceId::from_u128(13)→TraceId::from(13u128)SpanId::from_u64(14)→SpanId::from(14u64)Verification
serde_jsonjaeger_remote_samplerfeature continues to work with its own explicitserde_jsondependencyThe
serde_jsondependency is only used by thejaeger_remote_samplerfeature for parsing remote sampling configuration, and that feature already has its own explicit dependency onserde_json. This change reduces the dependency footprint for users who only need logging capabilities.Fixes #3104.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.